[patch #9821] Fix compiler warning avr.c:85:3 about misleading indentation

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch #9821] Fix compiler warning avr.c:85:3 about misleading indentation

Kevin Cuzner-2
URL:
  <https://savannah.nongnu.org/patch/?9821>

                 Summary: Fix compiler warning avr.c:85:3 about misleading
indentation
                 Project: AVR Downloader/UploaDEr
            Submitted by: aklieber
            Submitted on: Sun 23 Jun 2019 12:02:49 PM UTC
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Private
             Assigned to: None
        Originator Email:
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Indentation of functions avr_tpi_chip_erase and avr_tpi_program_enable is all
over the place. If keeping changes to a minimum is preferred over re-indenting
both functions, indentation of

err = pgm->cmd_tpi(pgm, cmd, sizeof(cmd), NULL, 0);

should be the same as the while loop two lines above.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 23 Jun 2019 12:02:49 PM UTC  Name: avrdude_avr.c_fix_indent.patch
Size: 4KiB   By: aklieber

<http://savannah.nongnu.org/patch/download.php?file_id=47131>

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9821>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
avrdude-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/avrdude-dev
Reply | Threaded
Open this post in threaded view
|

[patch #9821] Fix compiler warning avr.c:85:3 about misleading indentation

Kevin Cuzner-2
Update of patch #9821 (project avrdude):

                  Status:                    None => Done                  
             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #1:

Your patch tries to change a lot more than just this. I'd rather keep the
diffs minimal (otherwise, we had to change much more to get everything
beautiful and consistent).

I already committed a fix for the warning a few hours ago, but thanks for your
effort anyway!

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9821>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/