[patch #9728] Fix UsbTiny programmer

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch #9728] Fix UsbTiny programmer

Georg-Johann Lay-3
URL:
  <https://savannah.nongnu.org/patch/?9728>

                 Summary: Fix UsbTiny programmer
                 Project: AVR Downloader/UploaDEr
            Submitted by: facchinm
            Submitted on: Thu 22 Nov 2018 08:27:13 AM UTC
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email:
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

As reported on [https://github.com/arduino/Arduino/issues/8198] ,
`patch #8924: Enable TPI for usbtiny` broke the functionality of such
programmer for non TPI targets.

The refactor included reworking `usbtiny_initialize`, which used to call
`pgm->program_enable` once and, in case of failure, reset the programmer and
call it again.

The new code considers the return code successful if >=0, so the first failure
is not reported and the programmer is not being reset.

The attached patch restores the previous behaviour by checking if
`pgm->program_enable() == 0`



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thu 22 Nov 2018 08:27:13 AM UTC  Name: 0001-usbtiny.patch  Size: 415B  
By: facchinm

<http://savannah.nongnu.org/patch/download.php?file_id=45511>

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9728>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
avrdude-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/avrdude-dev
Reply | Threaded
Open this post in threaded view
|

[patch #9728] Fix UsbTiny programmer

Georg-Johann Lay-3
Update of patch #9728 (project avrdude):

                  Status:                    None => Done                  
             Assigned to:                    None => joerg_wunsch          
             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #1:

Applied in r1429, thanks!

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9728>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
avrdude-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/avrdude-dev