[bug #57154] iom1284p.h: typo of OCR1BL0:OCR1BL7, OCR1BH0:OCR1BH7, OCR3BL0:OCR3BL7 and OCR3AH0:OCR3AH7

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[bug #57154] iom1284p.h: typo of OCR1BL0:OCR1BL7, OCR1BH0:OCR1BH7, OCR3BL0:OCR3BL7 and OCR3AH0:OCR3AH7

Kevin Cuzner-2
URL:
  <https://savannah.nongnu.org/bugs/?57154>

                 Summary: iom1284p.h: typo of OCR1BL0:OCR1BL7,
OCR1BH0:OCR1BH7, OCR3BL0:OCR3BL7 and OCR3AH0:OCR3AH7
                 Project: AVR C Runtime Library
            Submitted by: webfreak
            Submitted on: Sat 02 Nov 2019 04:34:47 PM UTC
                Category: Header
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Header files
                  Status: None
        Percent Complete: 0%
             Assigned to: None
        Originator Email:
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 2.0.0
           Fixed Release: None

    _______________________________________________________

Details:

the registers OCR1BL0:OCR1BL7, OCR1BH0:OCR1BH7, OCR3BL0:OCR3BL7 and
OCR3AH0:OCR3AH7 are missing from the header file and where they should be
defined there are the registers with the names *A*n instead of *B*n defined.
(lines 693-710 and 802-819)

I'm not sure if the same code was copy-pasted to/from some other header files
because I have only looked at this file so far. I noticed this because it
redefined an already existing define for all the A values with the same
value.

What I also noticed but where I don't know if it's an issue: OCR2_0:OCR2_7 is
also defined twice. (once below OCR2A and once below OCR2B) I'm not sure if
this was intended because all other memory addresses usually have a different
naming and in the data sheet in 17.11.4 OCR2A – Output Compare Register A
and 17.11.5 OCR2A – Output Compare Register B they are named OCR2A[7:0] and
OCR2B[7:0] respectively instead of OCR2[7:0] (though changing these might
break programs relying on those defines)

I have also attached a patch (diff -rupN) which fixes the naming of the macros
mentioned in the bug title here but not the OCR2_n macros.




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 02 Nov 2019 04:34:48 PM UTC  Name: patch.txt  Size: 2KiB   By:
webfreak

<http://savannah.nongnu.org/bugs/download.php?file_id=47780>

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?57154>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/