[bug #55734] USBtiny programming of ATmega328p broken by Patch #9278

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug #55734] USBtiny programming of ATmega328p broken by Patch #9278

Georg-Johann Lay-3
URL:
  <https://savannah.nongnu.org/bugs/?55734>

                 Summary: USBtiny programming of ATmega328p broken by Patch
#9278
                 Project: AVR Downloader/UploaDEr
            Submitted by: ahroach
            Submitted on: Mon 18 Feb 2019 01:52:35 AM UTC
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: Austin Roach
        Originator Email:
             Open/Closed: Open
                 Release: SVN snapshot
         Discussion Lock: Any
     Programmer hardware: usbtiny
             Device type: ATmega328p

    _______________________________________________________

Details:

Programming an ATmega328p with a usbtiny-compatible programmer (Pocket AVR)
was broken for me by Patch #9278.[1]

The logic in Patch #9278 is flawed. usbtiny_program_enable() (which is
ultimately returning the value from usbtiny_cmd()) returns 1 on *success*.
With the patch applied, if usbtiny_program_enable() always succeeds, the
function will eventually fail and return -1. This is undoubtedly not the right
behavior.

There may be some devices for which usbtiny_cmd() appears to fail, even though
they are operating successfully. But breaking the operation of devices that
are actually behaving correctly can't be the right fix.

[1] https://savannah.nongnu.org/patch/?9728




    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?55734>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/


_______________________________________________
avrdude-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/avrdude-dev
Reply | Threaded
Open this post in threaded view
|

Re: [bug #55734] USBtiny programming of ATmega328p broken by Patch #9278

Austin Roach
Correction: the relevant patch number is Patch #9728. The referenced
URL is correct, but I transposed two digits in the description.

Cheers,
Austin

On Sun, Feb 17, 2019 at 8:52 PM Austin Roach <[hidden email]> wrote:

>
> URL:
>   <https://savannah.nongnu.org/bugs/?55734>
>
>                  Summary: USBtiny programming of ATmega328p broken by Patch
> #9278
>                  Project: AVR Downloader/UploaDEr
>             Submitted by: ahroach
>             Submitted on: Mon 18 Feb 2019 01:52:35 AM UTC
>                 Category: None
>                 Severity: 3 - Normal
>                 Priority: 5 - Normal
>               Item Group: None
>                   Status: None
>                  Privacy: Public
>              Assigned to: None
>          Originator Name: Austin Roach
>         Originator Email:
>              Open/Closed: Open
>                  Release: SVN snapshot
>          Discussion Lock: Any
>      Programmer hardware: usbtiny
>              Device type: ATmega328p
>
>     _______________________________________________________
>
> Details:
>
> Programming an ATmega328p with a usbtiny-compatible programmer (Pocket AVR)
> was broken for me by Patch #9278.[1]
>
> The logic in Patch #9278 is flawed. usbtiny_program_enable() (which is
> ultimately returning the value from usbtiny_cmd()) returns 1 on *success*.
> With the patch applied, if usbtiny_program_enable() always succeeds, the
> function will eventually fail and return -1. This is undoubtedly not the right
> behavior.
>
> There may be some devices for which usbtiny_cmd() appears to fail, even though
> they are operating successfully. But breaking the operation of devices that
> are actually behaving correctly can't be the right fix.
>
> [1] https://savannah.nongnu.org/patch/?9728
>
>
>
>
>     _______________________________________________________
>
> Reply to this item at:
>
>   <https://savannah.nongnu.org/bugs/?55734>
>
> _______________________________________________
>   Message sent via Savannah
>   https://savannah.nongnu.org/
>


--
Austin H. Roach
2288 S Walnut Grove Rd
Bloomfield, IN 47424
Cell: 812-512-4995
[hidden email]

_______________________________________________
avrdude-dev mailing list
[hidden email]
https://lists.nongnu.org/mailman/listinfo/avrdude-dev